[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v12 3/8] qmp: add QMP command x-query-virtio
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v12 3/8] qmp: add QMP command x-query-virtio |
Date: |
Fri, 11 Feb 2022 13:03:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Jonah Palmer <jonah.palmer@oracle.com> writes:
> From: Laurent Vivier <lvivier@redhat.com>
>
> This new command lists all the instances of VirtIODevices with
> their canonical QOM path and name.
>
> [Jonah: @virtio_list duplicates information that already exists in
> the QOM composition tree. However, extracting necessary information
> from this tree seems to be a bit convoluted.
>
> Instead, we still create our own list of realized virtio devices
> but use @qmp_qom_get with the device's canonical QOM path to confirm
> that the device exists and is realized. If the device exists but
> is actually not realized, then we remove it from our list (for
> synchronicity to the QOM composition tree).
>
> Also, the QMP command @x-query-virtio is redundant as @qom-list
> and @qom-get are sufficient to search '/machine/' for realized
> virtio devices. However, @x-query-virtio is much more convenient
> in listing realized virtio devices.]
Thanks for explaining this. Whether the convenience is worth the extra
code is for the virtio maintainer to decide.
> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v12 0/8] hmp,qmp: Add commands to introspect virtio devices, Jonah Palmer, 2022/02/10
- [PATCH v12 1/8] virtio: drop name parameter for virtio_init(), Jonah Palmer, 2022/02/10
- [PATCH v12 2/8] virtio: add vhost support for virtio devices, Jonah Palmer, 2022/02/10
- [PATCH v12 4/8] qmp: add QMP command x-query-virtio-status, Jonah Palmer, 2022/02/10
- [PATCH v12 3/8] qmp: add QMP command x-query-virtio, Jonah Palmer, 2022/02/10
- [PATCH v12 6/8] qmp: add QMP commands for virtio/vhost queue-status, Jonah Palmer, 2022/02/10
- [PATCH v12 5/8] qmp: decode feature & status bits in virtio-status, Jonah Palmer, 2022/02/10
- [PATCH v12 7/8] qmp: add QMP command x-query-virtio-queue-element, Jonah Palmer, 2022/02/10
- [PATCH v12 8/8] hmp: add virtio commands, Jonah Palmer, 2022/02/10