[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/24] iotest 302: use img_info_log() helper
From: |
Hanna Reitz |
Subject: |
[PULL 13/24] iotest 302: use img_info_log() helper |
Date: |
Tue, 1 Feb 2022 15:42:22 +0100 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Instead of qemu_img_log("info", ..) use generic helper img_info_log().
img_info_log() has smarter logic. For example it use filter_img_info()
to filter output, which in turns filter a compression type. So it will
help us in future when we implement a possibility to use zstd
compression by default (with help of some runtime config file or maybe
build option). For now to test you should recompile qemu with a small
addition into block/qcow2.c before
"if (qcow2_opts->has_compression_type":
if (!qcow2_opts->has_compression_type && version >= 3) {
qcow2_opts->has_compression_type = true;
qcow2_opts->compression_type = QCOW2_COMPRESSION_TYPE_ZSTD;
}
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20211223160144.1097696-12-vsementsov@virtuozzo.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
tests/qemu-iotests/302 | 4 +++-
tests/qemu-iotests/302.out | 7 +++----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/302 b/tests/qemu-iotests/302
index 5695af4914..a6d79e727b 100755
--- a/tests/qemu-iotests/302
+++ b/tests/qemu-iotests/302
@@ -34,6 +34,7 @@ from iotests import (
qemu_img_measure,
qemu_io,
qemu_nbd_popen,
+ img_info_log,
)
iotests.script_initialize(supported_fmts=["qcow2"])
@@ -88,6 +89,7 @@ with tarfile.open(tar_file, "w") as tar:
tar_file):
iotests.log("=== Target image info ===")
+ # Not img_info_log as it enforces imgfmt, but now we print info on raw
qemu_img_log("info", nbd_uri)
qemu_img(
@@ -99,7 +101,7 @@ with tarfile.open(tar_file, "w") as tar:
nbd_uri)
iotests.log("=== Converted image info ===")
- qemu_img_log("info", nbd_uri)
+ img_info_log(nbd_uri)
iotests.log("=== Converted image check ===")
qemu_img_log("check", nbd_uri)
diff --git a/tests/qemu-iotests/302.out b/tests/qemu-iotests/302.out
index e2f6077e83..3e7c281b91 100644
--- a/tests/qemu-iotests/302.out
+++ b/tests/qemu-iotests/302.out
@@ -6,14 +6,13 @@ virtual size: 448 KiB (458752 bytes)
disk size: unavailable
=== Converted image info ===
-image: nbd+unix:///exp?socket=SOCK_DIR/PID-nbd-sock
-file format: qcow2
+image: TEST_IMG
+file format: IMGFMT
virtual size: 1 GiB (1073741824 bytes)
-disk size: unavailable
cluster_size: 65536
Format specific information:
compat: 1.1
- compression type: zlib
+ compression type: COMPRESSION_TYPE
lazy refcounts: false
refcount bits: 16
corrupt: false
--
2.34.1
- Re: [PULL 10/24] iotest 065: explicit compression type, (continued)
- [PULL 07/24] iotests: drop qemu_img_verbose() helper, Hanna Reitz, 2022/02/01
- [PULL 14/24] qcow2: simple case support for downgrading of qcow2 images with zstd, Hanna Reitz, 2022/02/01
- [PULL 05/24] iotests: specify some unsupported_imgopts for python iotests, Hanna Reitz, 2022/02/01
- [PULL 04/24] iotests.py: implement unsupported_imgopts, Hanna Reitz, 2022/02/01
- [PULL 02/24] iotests/MRCE: Write data to source, Hanna Reitz, 2022/02/01
- [PULL 23/24] iotests/migration-permissions: New test, Hanna Reitz, 2022/02/01
- [PULL 20/24] iotest 214: explicit compression type, Hanna Reitz, 2022/02/01
- [PULL 21/24] iotests: declare lack of support for compresion_type in IMGOPTS, Hanna Reitz, 2022/02/01
- [PULL 18/24] iotests: bash tests: filter compression type, Hanna Reitz, 2022/02/01
- [PULL 13/24] iotest 302: use img_info_log() helper,
Hanna Reitz <=
- [PULL 15/24] iotests/common.rc: introduce _qcow2_dump_header helper, Hanna Reitz, 2022/02/01
- [PULL 17/24] iotest 39: use _qcow2_dump_header, Hanna Reitz, 2022/02/01
- [PULL 09/24] iotest 303: explicit compression type, Hanna Reitz, 2022/02/01
- [PULL 22/24] block-backend: Retain permissions after migration, Hanna Reitz, 2022/02/01
- [PULL 24/24] block.h: remove outdated comment, Hanna Reitz, 2022/02/01
- [PULL 03/24] iotests.py: img_info_log(): rename imgopts argument, Hanna Reitz, 2022/02/01
- [PULL 11/24] iotests.py: filter out successful output of qemu-img create, Hanna Reitz, 2022/02/01
- [PULL 16/24] iotests: massive use _qcow2_dump_header, Hanna Reitz, 2022/02/01
- [PULL 01/24] tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a', Hanna Reitz, 2022/02/01
- Re: [PULL 00/24] Block patches, Peter Maydell, 2022/02/01