[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] iotests/block-status-cache: New test
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 2/2] iotests/block-status-cache: New test |
Date: |
Fri, 28 Jan 2022 14:50:51 -0600 |
User-agent: |
NeoMutt/20211029-256-77b59a |
On Tue, Jan 18, 2022 at 06:00:00PM +0100, Hanna Reitz wrote:
> Add a new test to verify that want_zero=false block-status calls do not
> pollute the block-status cache for want_zero=true calls.
>
> We check want_zero=true calls and their results using `qemu-img map`
> (over NBD), and want_zero=false calls also using `qemu-img map` over
> NBD, but using the qemu:allocation-depth context.
>
> (This test case cannot be integrated into nbd-qemu-allocation, because
> that is a qcow2 test, and this is a raw test.)
>
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
> tests/qemu-iotests/tests/block-status-cache | 139 ++++++++++++++++++
> .../qemu-iotests/tests/block-status-cache.out | 5 +
> 2 files changed, 144 insertions(+)
> create mode 100755 tests/qemu-iotests/tests/block-status-cache
> create mode 100644 tests/qemu-iotests/tests/block-status-cache.out
Reviewed-by: Eric Blake <eblake@redhat.com>
As this was detected as a regression using NBD, I'm happy to add this
to my NBD queue, and will send a pull request soon.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org