Re: [PATCH v3 09/16] jobs: remove aiocontext locks since the functions are under BQL

[Emanuele Giuseppe Esposito]

On 19/01/2022 12:09, Paolo Bonzini wrote:
>> @@ -3707,15 +3707,11 @@ BlockJobInfoList *qmp_query_block_jobs(Error
>> **errp)
>>         for (job = block_job_next(NULL); job; job =
>> block_job_next(job)) {
>>           BlockJobInfo *value;
>> -        AioContext *aio_context;
>>             if (block_job_is_internal(job)) {
>>               continue;
>>           }
> 
> block_job_next, block_job_query, etc. do not have the _locked suffix. Is
> this because all block_job_ functions need the job_mutex held, or just
> laziness? :)
> 

I wasn't really sure whether to touch that API naming or not (+ laziness
:D )

But it makes sense to add _locked also there. Will do.

Thank you,
Emanuele