[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/7] drop libxml2 checks since libxml is not actually used
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 5/7] drop libxml2 checks since libxml is not actually used (for parallels) |
Date: |
Fri, 21 Jan 2022 11:29:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 1/20/22 12:30, Philippe Mathieu-Daudé wrote:
> From: Michael Tokarev <mjt@tls.msk.ru>
>
> For a long time, we assumed that libxml2 is neecessary for parallels
> block format support (block/parallels*). However, this format actually
> does not use libxml [*]. Since this is the only user of libxml2 in
> while qemu tree, we can drop all libxml2 checks and dependencies too.
>
> It is even more: --enable-parallels configure option was the only
> option which was silently ignored when it's (fake) dependency
> (libxml2) isn't installed.
>
> Drop all mentions of libxml2.
>
> [*] Actually the basis for libxml use were merged in commit 25bfd5a75
> but the implementation was never merged:
>
> https://lore.kernel.org/qemu-devel/70227bbd-a517-70e9-714f-e6e0ec431be9@openvz.org/
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Message-Id: <20220119090423.149315-1-mjt@msgid.tls.msk.ru>
> [PMD: Updated description and adapted to use lcitool]
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> meson.build | 6 ------
> block/meson.build | 3 +--
> meson_options.txt | 2 --
> scripts/ci/org.centos/stream/8/x86_64/configure | 1 -
> scripts/coverity-scan/coverity-scan.docker | 1 -
> scripts/coverity-scan/run-coverity-scan | 2 +-
> 6 files changed, 2 insertions(+), 13 deletions(-)
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v3 0/7] tests: Refresh lcitool submodule & remove libxml2, Philippe Mathieu-Daudé, 2022/01/20
- [PATCH v3 7/7] tests: Manually remove libxml2 on MSYS2 runners, Philippe Mathieu-Daudé, 2022/01/20
- [PATCH v3 5/7] drop libxml2 checks since libxml is not actually used (for parallels), Philippe Mathieu-Daudé, 2022/01/20
- Re: [PATCH v3 5/7] drop libxml2 checks since libxml is not actually used (for parallels),
Philippe Mathieu-Daudé <=
- [PATCH v3 3/7] tests: Refresh lcitool submodule, Philippe Mathieu-Daudé, 2022/01/20
- [PATCH v3 1/7] MAINTAINERS: Cover lcitool submodule with build test / automation, Philippe Mathieu-Daudé, 2022/01/20
- [PATCH v3 4/7] tests/lcitool: Install libibumad to cover RDMA on Debian based distros, Philippe Mathieu-Daudé, 2022/01/20
- [PATCH v3 2/7] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files, Philippe Mathieu-Daudé, 2022/01/20
- [PATCH v3 6/7] tests/lcitool: Remove libxml2, Philippe Mathieu-Daudé, 2022/01/20