[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/10] hw/dma: Move ScatterGatherEntry / QEMUSGList declar
From: |
David Hildenbrand |
Subject: |
Re: [PATCH v3 09/10] hw/dma: Move ScatterGatherEntry / QEMUSGList declarations around |
Date: |
Wed, 12 Jan 2022 10:10:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 11.01.22 19:43, Philippe Mathieu-Daudé wrote:
> In the next commit we will use the dma_addr_t type in the QEMUSGList
> structure. Since currently dma_addr_t is defined after QEMUSGList,
> move the declarations to have dma_addr_t defined first. This is a
> pure code-movement patch.
Oh, that was the underlying reason for the movement. Anyhow, this
certainly makes the next patch easier to review
Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/sysemu/dma.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h
> index 0db2478a506..c992d9d5d6b 100644
> --- a/include/sysemu/dma.h
> +++ b/include/sysemu/dma.h
> @@ -15,22 +15,11 @@
> #include "block/block.h"
> #include "block/accounting.h"
>
> -typedef struct ScatterGatherEntry ScatterGatherEntry;
> -
> typedef enum {
> DMA_DIRECTION_TO_DEVICE = 0,
> DMA_DIRECTION_FROM_DEVICE = 1,
> } DMADirection;
>
> -struct QEMUSGList {
> - ScatterGatherEntry *sg;
> - int nsg;
> - int nalloc;
> - size_t size;
> - DeviceState *dev;
> - AddressSpace *as;
> -};
> -
> /*
> * When an IOMMU is present, bus addresses become distinct from
> * CPU/memory physical addresses and may be a different size. Because
> @@ -43,6 +32,17 @@ typedef uint64_t dma_addr_t;
> #define DMA_ADDR_BITS 64
> #define DMA_ADDR_FMT "%" PRIx64
>
> +typedef struct ScatterGatherEntry ScatterGatherEntry;
> +
> +struct QEMUSGList {
> + ScatterGatherEntry *sg;
> + int nsg;
> + int nalloc;
> + size_t size;
> + DeviceState *dev;
> + AddressSpace *as;
> +};
> +
> static inline void dma_barrier(AddressSpace *as, DMADirection dir)
> {
> /*
--
Thanks,
David / dhildenb
- [PATCH v3 02/10] hw/nvram: Restrict fw_cfg QOM interface to sysemu and tools, (continued)
- [PATCH v3 02/10] hw/nvram: Restrict fw_cfg QOM interface to sysemu and tools, Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 03/10] hw/pci: Restrict pci-bus stub to sysemu, Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 04/10] hw/pci: Document pci_dma_map(), Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 05/10] hw/dma: Remove CONFIG_USER_ONLY check, Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 06/10] hw/rdma/rdma_utils: Rename rdma_pci_dma_map 'len' argument, Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 07/10] hw/scsi: Rename SCSIRequest::resid as 'residual', Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 08/10] hw/dma: Fix format string issues using dma_addr_t, Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 09/10] hw/dma: Move ScatterGatherEntry / QEMUSGList declarations around, Philippe Mathieu-Daudé, 2022/01/11
- [PATCH v3 10/10] hw/dma: Use dma_addr_t type definition when relevant, Philippe Mathieu-Daudé, 2022/01/11
- Re: [PATCH v3 00/10] hw/dma: Use dma_addr_t type definition when relevant, Peter Xu, 2022/01/11
- Re: [PATCH v3 00/10] hw/dma: Use dma_addr_t type definition when relevant, Philippe Mathieu-Daudé, 2022/01/18