Re: [PATCH 1/1] hw/usb: pacify xhciwmi.exe warning

[Yan Vugenfirer]

On Tue, Jan 11, 2022 at 3:20 PM Denis V. Lunev <den@openvz.org> wrote:

On 12/23/21 12:54 PM, Denis V. Lunev wrote:
> xhciwmi.exe is used inside Windows 2022 SVVP tests. This tool called as
> 'xhciwmi.exe --verify' reports that 'The firmware loaded on this
> controller has known bugs and/or compatibility issues'. This is just
> a warning but there is no particular sense to ignore it.
>
> This patch just pacifies the tool.
>
> There is a big question whether this change should be put using
> machine type mechanics, but at my opinion this would be an overkill.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Tested-by: Pavel Polozov <pavel.polozov@virtuozzo.com>
> CC: Yan Vugenfirer <yvugenfi@redhat.com>
> CC: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb/hcd-xhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index e01700039b..6fead7552d 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -2519,7 +2519,7 @@ static void xhci_process_commands(XHCIState *xhci)
>          case CR_VENDOR_NEC_FIRMWARE_REVISION:
>              if (xhci->nec_quirks) {
>                  event.type = 48; /* NEC reply */
> -                event.length = 0x3025;
> +                event.length = 0x3034;
>              } else {
>                  event.ccode = CC_TRB_ERROR;
>              }
ping

 

Reviewed-by: Yan Vugenfirer <yvugenfi@redhat.com>