[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 16/16] block_job_query: remove atomic read
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v3 16/16] block_job_query: remove atomic read |
Date: |
Wed, 5 Jan 2022 09:02:08 -0500 |
Not sure what the atomic here was supposed to do, since job.busy
is protected by the job lock. Since the whole function
is called under job_mutex, just remove the atomic.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
blockjob.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index 468ba735c5..d1d8808a56 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -335,13 +335,13 @@ BlockJobInfo *block_job_query(BlockJob *job, Error **errp)
info = g_new0(BlockJobInfo, 1);
info->type = g_strdup(job_type_str(&job->job));
info->device = g_strdup(job->job.id);
- info->busy = qatomic_read(&job->job.busy);
+ info->busy = job->job.busy;
info->paused = job->job.pause_count > 0;
info->offset = progress_current;
info->len = progress_total;
info->speed = job->speed;
info->io_status = job->iostatus;
- info->ready = job_is_ready(&job->job),
+ info->ready = job_is_ready_locked(&job->job),
info->status = job->job.status;
info->auto_finalize = job->job.auto_finalize;
info->auto_dismiss = job->job.auto_dismiss;
--
2.31.1
- [PATCH v3 14/16] job.c: use job_get_aio_context(), (continued)
[PATCH v3 13/16] jobs: add job lock in find_* functions, Emanuele Giuseppe Esposito, 2022/01/05
[PATCH v3 10/16] jobs: protect jobs with job_lock/unlock, Emanuele Giuseppe Esposito, 2022/01/05
[PATCH v3 16/16] block_job_query: remove atomic read,
Emanuele Giuseppe Esposito <=
[PATCH v3 09/16] jobs: remove aiocontext locks since the functions are under BQL, Emanuele Giuseppe Esposito, 2022/01/05
[PATCH v3 12/16] jobs: use job locks and helpers also in the unit tests, Emanuele Giuseppe Esposito, 2022/01/05
[PATCH v3 04/16] job.h: define unlocked functions, Emanuele Giuseppe Esposito, 2022/01/05
[PATCH v3 03/16] job.h: define locked functions, Emanuele Giuseppe Esposito, 2022/01/05