RE: [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device

[Pei, Andy]

Hi Raphael,

Thanks for your reply.
I will fix the grammar mistake in V2.

-----Original Message-----
From: Raphael Norwitz <raphael.norwitz@nutanix.com> 
Sent: Tuesday, November 30, 2021 5:58 AM
To: Pei, Andy <andy.pei@intel.com>
Cc: qemu-devel@nongnu.org; qemu-block@nongnu.org; Liu, Changpeng 
<changpeng.liu@intel.com>; Raphael Norwitz <raphael.norwitz@nutanix.com>; 
mst@redhat.com; kwolf@redhat.com; mreitz@redhat.com
Subject: Re: [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature 
for virtio blk device

Just a commit message nit. Otherwise I'm happy with this. OFC should not be 
queued for 6.2.

On Fri, Nov 26, 2021 at 10:00:18AM +0800, Andy Pei wrote:
> Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX virtio blk device to 
> avoid guest DMA request size is too large to exceed hardware spec.

Grammar here. Should be something like "...DMA request sizes which are to large 
for the hardware spec".

> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>

Acked-by: Raphael Norwitz <raphael.norwitz@nutanix.com>

> ---
>  hw/block/vhost-user-blk.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c 
> index ba13cb8..eb1264a 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice 
> *vdev,
>      VHostUserBlk *s = VHOST_USER_BLK(vdev);
>  
>      /* Turn on pre-defined features */
> +    virtio_add_feature(&features, VIRTIO_BLK_F_SIZE_MAX);
>      virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX);
>      virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
>      virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
> --
> 1.8.3.1
>