[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 0/8] hmp, qmp: Add commands to introspect virtio devices
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH v10 0/8] hmp, qmp: Add commands to introspect virtio devices |
Date: |
Mon, 06 Dec 2021 14:50:57 +0100 |
On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote:
> This series introduces new QMP/HMP commands to dump the status of a
> virtio device at different levels.
>
> [Jonah: Rebasing previous patchset from Nov. 10 (v9). Original patches
> are by Laurent Vivier from May 2020.
>
> Rebase from v9 to v10 includes reformatting virtio.json examples and
> command structures for better consistency. Also removed all enums from
> virtio.json and replaced their purpose with string literals.
>
> Removed @ndescs from VirtioQueueElement, as the number of descriptors
> can be inferred from the length of the @descs chain.
>
> Lastly, removed the examples in hmp-commands-info.hx to fix 'inconsistent
> literal block quoting' warning from Sphinx.]
I have not followed the entire discussion. AFAICS this is intended to monitor
status information on virtio level only, like virtqueue fill status, etc.
One thing that I am looking for is monitoring device specific information
above virtio level, e.g. certain performance numbers or statistics that only
make sense for the specific device. That would not fit into any of these
commands, right?
Best regards,
Christian Schoenebeck
- Re: [PATCH v10 1/8] virtio: drop name parameter for virtio_init(), (continued)
- [PATCH v10 3/8] qmp: add QMP command x-query-virtio, Jonah Palmer, 2021/12/06
- [PATCH v10 2/8] virtio: add vhost support for virtio devices, Jonah Palmer, 2021/12/06
- [PATCH v10 7/8] qmp: add QMP command x-query-virtio-queue-element, Jonah Palmer, 2021/12/06
- [PATCH v10 6/8] qmp: add QMP commands for virtio/vhost queue-status, Jonah Palmer, 2021/12/06
- [PATCH v10 5/8] qmp: decode feature & status bits in virtio-status, Jonah Palmer, 2021/12/06
- [PATCH v10 8/8] hmp: add virtio commands, Jonah Palmer, 2021/12/06
- Re: [PATCH v10 0/8] hmp, qmp: Add commands to introspect virtio devices,
Christian Schoenebeck <=