On 17/11/2021 11.59, Hanna Reitz wrote:
> On 17.11.21 11:07, Thomas Huth wrote:
>> +++ 297.out.bad
>> @@ -1,2 +1,21 @@
>> === pylint ===
>> +************* Module image-fleecing
>> +tests/image-fleecing:34:24: C0326: Exactly one space required after comma
>> +patterns = [('0x5d', '0', '64k'),
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:35:25: C0326: Exactly one space required after comma
>> + ('0xd5', '1M', '64k'),
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:36:26: C0326: Exactly one space required after comma
>> + ('0xdc', '32M', '64k'),
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:39:25: C0326: Exactly one space required after comma
>> +overwrite = [('0xab', '0', '64k'), # Full overwrite
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:48:32: C0326: Exactly one space required after comma
>> +remainder = [('0xd5', '0x108000', '32k'), # Right-end of partial-left [1]
>> + ^ (bad-whitespace)
>> +tests/image-fleecing:49:27: C0326: Exactly one space required after comma
>> + ('0xdc', '32M', '32k'), # Left-end of partial-right [2]
>> + ^ (bad-whitespace)
>
> This could be because your pylint is too old. At least for the python/
> tests we at least require 2.8.0
> (https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html) and
> bad-whitespace was removed in 2.6.
Thanks, updating pylint fixed this problem, indeed!
But maybe the iotests should check the pylint version before using it?
Ideally, yes ... sorry, it's been a lot of work to try and get the python testing for this stuff in order.
FWIW, the GitLab CI jobs for check-python-pipenv and check-python-tox now basically run "iotest 297", and those jobs will use virtual environments to force a supportable version of pylint/mypy/etc. These targets are the ones I put the most effort into, and those are the ones that "just work".
It's on my list to, one way or another, drop 297 and use the python testing infra to cover this instead, but I have some ground to cover for usability/convenience before I can pitch it.
(At the risk of sounding like I am task offloading, if you send a patch to add version checking to 297, I can review it.)