[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/13] docs: Deprecate incorrectly typed device_add arguments
From: |
Kevin Wolf |
Subject: |
[PULL 11/13] docs: Deprecate incorrectly typed device_add arguments |
Date: |
Mon, 15 Nov 2021 15:54:07 +0100 |
While introducing a non-QemuOpts code path for device creation for JSON
-device, we noticed that QMP device_add doesn't check its input
correctly (accepting arguments that should have been rejected), and that
users may be relying on this behaviour (libvirt did until it was fixed
recently).
Let's use a deprecation period before we fix this bug in QEMU to avoid
nasty surprises for users.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20211111143530.18985-1-kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
docs/about/deprecated.rst | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 600031210d..c03fcf951f 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -250,6 +250,20 @@ options are removed in favor of using explicit
``blockdev-create`` and
``blockdev-add`` calls. See :doc:`/interop/live-block-operations` for
details.
+Incorrectly typed ``device_add`` arguments (since 6.2)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Due to shortcomings in the internal implementation of ``device_add``, QEMU
+incorrectly accepts certain invalid arguments: Any object or list arguments are
+silently ignored. Other argument types are not checked, but an implicit
+conversion happens, so that e.g. string values can be assigned to integer
+device properties or vice versa.
+
+This is a bug in QEMU that will be fixed in the future so that previously
+accepted incorrect commands will return an error. Users should make sure that
+all arguments passed to ``device_add`` are consistent with the documented
+property types.
+
System accelerators
-------------------
--
2.31.1
- [PULL 00/13] Block layer patches, Kevin Wolf, 2021/11/15
- [PULL 01/13] stream: Traverse graph after modification, Kevin Wolf, 2021/11/15
- [PULL 04/13] block: Drop detached child from ignore list, Kevin Wolf, 2021/11/15
- [PULL 02/13] block: Manipulate children list in .attach/.detach, Kevin Wolf, 2021/11/15
- [PULL 05/13] block: Pass BdrvChild ** to replace_child_noperm, Kevin Wolf, 2021/11/15
- [PULL 06/13] block: Restructure remove_file_or_backing_child(), Kevin Wolf, 2021/11/15
- [PULL 10/13] iotests/030: Unthrottle parallel jobs in reverse, Kevin Wolf, 2021/11/15
- [PULL 11/13] docs: Deprecate incorrectly typed device_add arguments,
Kevin Wolf <=
- [PULL 08/13] block: Let replace_child_tran keep indirect pointer, Kevin Wolf, 2021/11/15
- [PULL 03/13] block: Unite remove_empty_child and child_free, Kevin Wolf, 2021/11/15
- [PULL 12/13] file-posix: Fix alignment after reopen changing O_DIRECT, Kevin Wolf, 2021/11/15
- [PULL 13/13] softmmu/qdev-monitor: fix use-after-free in qdev_set_id(), Kevin Wolf, 2021/11/15
- [PULL 07/13] transactions: Invoke clean() after everything else, Kevin Wolf, 2021/11/15
- [PULL 09/13] block: Let replace_child_noperm free children, Kevin Wolf, 2021/11/15
- Re: [PULL 00/13] Block layer patches, Richard Henderson, 2021/11/15
- Re: [PULL 00/13] Block layer patches, Philippe Mathieu-Daudé, 2021/11/15