[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] job.c: add missing notifier initialization
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v1] job.c: add missing notifier initialization |
|
Date: |
Wed, 3 Nov 2021 17:32:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/3/21 17:21, Emanuele Giuseppe Esposito wrote:
> It seems that on_idle list is not properly initialized like
> the other notifiers.
>
Cc: qemu-stable@nongnu.org
Fixes: 34dc97b9a0e ("blockjob: Wake up BDS when job becomes idle")
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> job.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/job.c b/job.c
> index dbfa67bb0a..54db80df66 100644
> --- a/job.c
> +++ b/job.c
> @@ -352,6 +352,7 @@ void *job_create(const char *job_id, const JobDriver
> *driver, JobTxn *txn,
> notifier_list_init(&job->on_finalize_completed);
> notifier_list_init(&job->on_pending);
> notifier_list_init(&job->on_ready);
> + notifier_list_init(&job->on_idle);
>
> job_state_transition(job, JOB_STATUS_CREATED);
> aio_timer_init(qemu_get_aio_context(), &job->sleep_timer,
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>