[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/8] python/machine: Handle QMP errors on close more metic
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH v5 2/8] python/machine: Handle QMP errors on close more meticulously |
|
Date: |
Thu, 28 Oct 2021 12:01:10 +0200 |
Am 27.10.2021 um 19:49 hat John Snow geschrieben:
> This reply is long, sorry.
And after writing half of a very long reply myself, I noticed that I was
just very confused, so sorry for making you write a long text for no
real reason (well, at least for my first point - for the second one,
your explanation was very helpful, so thanks for that).
Somehow I ended up completely ignoring the context of the code (it's run
as part of shutdown functions) and instead thought of the general
condition of QMP connections going away anywhere in the code.
I suppose this could be a relevant concern in an actually asynchronous
client that may read from the socket (and encounter an error if the QEMU
process has already gone away and closed the connection) at any time,
but that's not what machine.py is meant for, at least not for now.
So I'll just delete what I already wrote. This patch should be fine.
Kevin
[PATCH v5 1/8] python/machine: remove has_quit argument, John Snow, 2021/10/26
[PATCH v5 3/8] python/aqmp: Remove scary message, John Snow, 2021/10/26
[PATCH v5 8/8] python, iotests: replace qmp with aqmp, John Snow, 2021/10/26
[PATCH v5 7/8] python/aqmp: Create sync QMP wrapper for iotests, John Snow, 2021/10/26
[PATCH v5 4/8] iotests: Accommodate async QMP Exception classes, John Snow, 2021/10/26
[PATCH v5 6/8] iotests/300: avoid abnormal shutdown race condition, John Snow, 2021/10/26
[PATCH v5 5/8] iotests: Conditionally silence certain AQMP errors, John Snow, 2021/10/26