qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 08/15] iotests/297: Change run_linter() to raise an except


From: John Snow
Subject: Re: [PATCH v2 08/15] iotests/297: Change run_linter() to raise an exception on failure
Date: Tue, 26 Oct 2021 13:59:58 -0400



On Tue, Oct 26, 2021 at 6:10 AM Hanna Reitz <hreitz@redhat.com> wrote:
On 19.10.21 16:49, John Snow wrote:
> Instead of using a process return code as the python function return
> value (or just not returning anything at all), allow run_linter() to
> raise an exception instead.
>
> The responsibility for printing output on error shifts from the function
> itself to the caller, who will know best how to present/format that
> information. (Also, "suppress_output" is now a lot more accurate of a
> parameter name.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/qemu-iotests/297 | 24 ++++++++++++++----------
>   1 file changed, 14 insertions(+), 10 deletions(-)

Thanks! :)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>


No problem. Thanks for taking the time to review it!

--js

reply via email to

[Prev in Thread] Current Thread [Next in Thread]