[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/9] qapi: New special feature flag "unstable"
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 1/9] qapi: New special feature flag "unstable" |
Date: |
Tue, 26 Oct 2021 07:35:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> On Mon, Oct 25, 2021 at 1:26 AM Markus Armbruster <armbru@redhat.com> wrote:
>
>> By convention, names starting with "x-" are experimental. The parts
>> of external interfaces so named may be withdrawn or changed
>> incompatibly in future releases.
>>
>> Drawback: promoting something from experimental to stable involves a
>> name change. Client code needs to be updated.
>>
>> Moreover, the convention is not universally observed:
>>
>> * QOM type "input-barrier" has properties "x-origin", "y-origin".
>> Looks accidental, but it's ABI since 4.2.
>>
>> * QOM types "memory-backend-file", "memory-backend-memfd",
>> "memory-backend-ram", and "memory-backend-epc" have a property
>> "x-use-canonical-path-for-ramblock-id" that is documented to be
>> stable despite its name.
>>
>> We could document these exceptions, but documentation helps only
>> humans. We want to recognize "unstable" in code, like "deprecated".
>>
>> Replace the convention by a new special feature flag "unstable". It
>> will be recognized by the QAPI generator, like the existing feature
>> flag "deprecated", and unlike regular feature flags.
>>
>> This commit updates documentation and prepares tests. The next commit
>> updates the QAPI schema. The remaining patches update the QAPI
>> generator and wire up -compat policy checking.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
[...]
> Feels odd to combine the doc update *and* test prep, but eh, whatever.
I admit this is what was left after patch splitting and reshuffling.
> Reviewed-by: John Snow <jsnow@redhat.com>
Thanks!
- Re: [PATCH 7/9] qapi: Generalize enum member policy checking, (continued)
[PATCH 1/9] qapi: New special feature flag "unstable", Markus Armbruster, 2021/10/25
Re: [PATCH 1/9] qapi: New special feature flag "unstable", John Snow, 2021/10/25
- Re: [PATCH 1/9] qapi: New special feature flag "unstable",
Markus Armbruster <=
Re: [PATCH 1/9] qapi: New special feature flag "unstable", Kevin Wolf, 2021/10/26
Re: [PATCH 1/9] qapi: New special feature flag "unstable", Markus Armbruster, 2021/10/26
Re: [PATCH 1/9] qapi: New special feature flag "unstable", Kevin Wolf, 2021/10/26
Re: [PATCH 1/9] qapi: New special feature flag "unstable", Markus Armbruster, 2021/10/28
Re: [PATCH 1/9] qapi: New special feature flag "unstable", Daniel P . Berrangé, 2021/10/26
Re: [PATCH 1/9] qapi: New special feature flag "unstable", Markus Armbruster, 2021/10/26
Re: [PATCH 1/9] qapi: New special feature flag "unstable", Daniel P . Berrangé, 2021/10/26