Re: [PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts

From:	Damien Hedde
Subject:	Re: [PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts
Date:	Wed, 13 Oct 2021 15:41:19 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2



On 10/8/21 15:34, Kevin Wolf wrote:

DeviceState.id is a pointer to a string that is stored in the QemuOpts
object DeviceState.opts and freed together with it. We want to create
devices without going through QemuOpts in the future, so make this a
separately allocated string.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>



Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 02/15] net/vhost-user: Fix device compatibility check, (continued)
- [PATCH v2 07/15] qdev: Avoid using string visitor for properties, Kevin Wolf, 2021/10/08
- [PATCH v2 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id, Kevin Wolf, 2021/10/08
  - Re: [PATCH v2 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id, Eric Blake, 2021/10/11
    - Re: [PATCH v2 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id, Damien Hedde, 2021/10/13
    - Re: [PATCH v2 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id, Eric Blake, 2021/10/13
    - Re: [PATCH v2 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id, Kevin Wolf, 2021/10/15
- [PATCH v2 05/15] iotests/245: Fix type for iothread property, Kevin Wolf, 2021/10/08
- [PATCH v2 10/15] qemu-option: Allow deleting opts during qemu_opts_foreach(), Kevin Wolf, 2021/10/08
- [PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts, Kevin Wolf, 2021/10/08
  - Re: [PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts, Damien Hedde <=
- [PATCH v2 13/15] virtio-net: Avoid QemuOpts in failover_find_primary_device(), Kevin Wolf, 2021/10/08
- [PATCH v2 11/15] qdev: Add Error parameter to hide_device() callbacks, Kevin Wolf, 2021/10/08
- [PATCH v2 12/15] virtio-net: Store failover primary opts pointer locally, Kevin Wolf, 2021/10/08
  - Re: [PATCH v2 12/15] virtio-net: Store failover primary opts pointer locally, Laurent Vivier, 2021/10/19
    - Re: [PATCH v2 12/15] virtio-net: Store failover primary opts pointer locally, Kevin Wolf, 2021/10/19
- [PATCH v2 14/15] qdev: Base object creation on QDict rather than QemuOpts, Kevin Wolf, 2021/10/08
  - Re: [PATCH v2 14/15] qdev: Base object creation on QDict rather than QemuOpts, Laurent Vivier, 2021/10/08
- [PATCH v2 15/15] vl: Enable JSON syntax for -device, Kevin Wolf, 2021/10/08
- Re: [PATCH v2 00/15] qdev: Add JSON -device, Michael S. Tsirkin, 2021/10/13
  - Re: [PATCH v2 00/15] qdev: Add JSON -device, Kevin Wolf, 2021/10/13

Prev by Date: Re: [PATCH v2 03/15] net/vhost-vdpa: Fix device compatibility check
Next by Date: Re: [PATCH v3 0/7] Switch iotests to using Async QMP
Previous by thread: [PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts
Next by thread: [PATCH v2 13/15] virtio-net: Avoid QemuOpts in failover_find_primary_device()
Index(es):
- Date
- Thread