Re: [PATCH v2] vmdk: allow specification of tools version

[Hanna Reitz]

On 13.09.21 15:04, Thomas Weißschuh wrote:
> VMDK files support an attribute that represents the version of the guest
> tools that are installed on the disk.
> This attribute is used by vSphere before a machine has been started to
> determine if the VM has the guest tools installed.
> This is important when configuring "Operating system customizations" in
> vSphere, as it checks for the presence of the guest tools before
> allowing those customizations.
> Thus when the VM has not yet booted normally it would be impossible to
> customize it, therefore preventing a customized first-boot.
>
> The attribute should not hurt on disks that do not have the guest tools
> installed and indeed the VMware tools also unconditionally add this
> attribute.
> (Defaulting to the value "2147483647", as is done in this patch)
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh.ext@zeiss.com>
> ---
>
> v1: 
> https://lore.kernel.org/qemu-devel/20210908174250.12946-1-thomas.weissschuh.ext@zeiss.com/
>
> v1 -> v2:
> * Expand QAPI docs (Eric Blake)
>
>   block/vmdk.c         | 24 ++++++++++++++++++++----
>   qapi/block-core.json |  3 +++
>   2 files changed, 23 insertions(+), 4 deletions(-)

[...]

> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index c8ce1d9d5d..42431f52d0 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4597,6 +4597,8 @@
>   # @adapter-type: The adapter type used to fill in the descriptor. Default: 
> ide.
>   # @hwversion: Hardware version. The meaningful options are "4" or "6".
>   #             Default: "4".
> +# @toolsversion: VMware guest tools version.
> +                 Default: "2147483647" (Since 6.2)

There’s a # missing at the start of the line, and so this doesn’t compile.

I’ve added it (hope that’s OK for you) and taken this patch to my block 
branch:

https://gitlab.com/hreitz/qemu/-/commits/block/

Hanna