[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/13] include/block.h: remove outdated comment
From: |
Kevin Wolf |
Subject: |
[PULL 01/13] include/block.h: remove outdated comment |
Date: |
Wed, 6 Oct 2021 12:59:11 +0200 |
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
There are a couple of errors in bdrv_drained_begin header comment:
- block_job_pause does not exist anymore, it has been replaced
with job_pause in b15de82867
- job_pause is automatically invoked as a .drained_begin callback
(child_job_drained_begin) by the child_job BdrvChildClass struct
in blockjob.c. So no additional pause should be required.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-Id: <20210903113800.59970-1-eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
include/block/block.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index 740038a892..ab987e8a99 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -751,9 +751,7 @@ bool bdrv_drain_poll(BlockDriverState *bs, bool recursive,
* bdrv_drained_begin:
*
* Begin a quiesced section for exclusive access to the BDS, by disabling
- * external request sources including NBD server and device model. Note that
- * this doesn't block timers or coroutines from submitting more requests, which
- * means block_job_pause is still necessary.
+ * external request sources including NBD server, block jobs, and device model.
*
* This function can be recursive.
*/
--
2.31.1
- [PULL 00/13] Block layer patches, Kevin Wolf, 2021/10/06
- [PULL 02/13] qemu-storage-daemon: Only display FUSE help when FUSE is built-in, Kevin Wolf, 2021/10/06
- [PULL 01/13] include/block.h: remove outdated comment,
Kevin Wolf <=
- [PULL 03/13] block: implement bdrv_new_open_driver_opts(), Kevin Wolf, 2021/10/06
- [PULL 04/13] block: bdrv_insert_node(): fix and improve error handling, Kevin Wolf, 2021/10/06
- [PULL 05/13] block: bdrv_insert_node(): doc and style, Kevin Wolf, 2021/10/06
- [PULL 06/13] block: bdrv_insert_node(): don't use bdrv_open(), Kevin Wolf, 2021/10/06
- [PULL 07/13] iotests/image-fleecing: declare requirement of copy-before-write, Kevin Wolf, 2021/10/06
- [PULL 08/13] block: introduce max_hw_iov for use in scsi-generic, Kevin Wolf, 2021/10/06
- [PULL 10/13] iotests/linters: check mypy files all at once, Kevin Wolf, 2021/10/06
- [PULL 09/13] iotests: add 'qemu' package location to PYTHONPATH in testenv, Kevin Wolf, 2021/10/06
- [PULL 11/13] iotests/mirror-top-perms: Adjust imports, Kevin Wolf, 2021/10/06
- [PULL 12/13] iotests/migrate-bitmaps-test: delint, Kevin Wolf, 2021/10/06