[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 13/16] iotests/linters: Add entry point for Python CI linters
From: |
John Snow |
Subject: |
[PATCH v3 13/16] iotests/linters: Add entry point for Python CI linters |
Date: |
Thu, 16 Sep 2021 00:09:52 -0400 |
Add a main() function to linters.py so that the Python CI infrastructure
has something it can run.
Now, linters.py represents an invocation of the linting scripts that
more resembles a "normal" execution of pylint/mypy, like you'd expect to
use if 'qemu' was a bona-fide package you obtained from PyPI.
297, by contrast, now represents the iotests-specific configuration bits
you need to get it to function correctly as a part of iotests, and with
'qemu' as a namespace package that isn't "installed" to the current
environment, but just lives elsewhere in our source tree.
By doing this, we will able to run the same linting configuration from
the Python CI tests without calling iotest logging functions or messing
around with PYTHONPATH / MYPYPATH.
iotest 297 continues to operate in a standalone fashion for now --
presumably, it's convenient for block maintainers and contributors to
run in this manner. We can either remove this functionality at a later
date if everyone is happy with the Python CI, or we can opt to continue
to maintain it. Please let me know how you feel.
See the following commit for how this is used from the Python packaging side.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/linters.py | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/qemu-iotests/linters.py b/tests/qemu-iotests/linters.py
index e263b7cbee..4df062a973 100755
--- a/tests/qemu-iotests/linters.py
+++ b/tests/qemu-iotests/linters.py
@@ -115,3 +115,16 @@ def run_linters(
print(p.stdout)
return ret
+
+
+def main() -> int:
+ """
+ Used by the Python CI system as an entry point to run these linters.
+ """
+ directory = os.path.dirname(os.path.realpath(__file__))
+ files = get_test_files(directory)
+ return run_linters(files, directory)
+
+
+if __name__ == '__main__':
+ sys.exit(main())
--
2.31.1
- [PATCH v3 08/16] iotests/297: Create main() function, (continued)
- [PATCH v3 08/16] iotests/297: Create main() function, John Snow, 2021/09/16
- [PATCH v3 09/16] iotests/297: Separate environment setup from test execution, John Snow, 2021/09/16
- [PATCH v3 10/16] iotests/297: Add 'directory' argument to run_linters, John Snow, 2021/09/16
- [PATCH v3 11/16] iotests/297: return error code from run_linters(), John Snow, 2021/09/16
- [PATCH v3 13/16] iotests/linters: Add entry point for Python CI linters,
John Snow <=
- [PATCH v3 15/16] python: Add iotest linters to test suite, John Snow, 2021/09/16
- [PATCH v3 12/16] iotests/297: split linters.py off from 297, John Snow, 2021/09/16
- [PATCH v3 14/16] iotests/linters: Add workaround for mypy bug #9852, John Snow, 2021/09/16
- [PATCH v3 16/16] iotests/linters: check mypy files all at once, John Snow, 2021/09/16