[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O and graph API |
|
Date: |
Wed, 15 Sep 2021 15:38:50 +0100 |
On Wed, Sep 15, 2021 at 02:14:08PM +0200, Paolo Bonzini wrote:
> On 13/09/21 15:27, Stefan Hajnoczi wrote:
> > > +/*
> > > + * I/O API functions. These functions are thread-safe, and therefore
> > > + * can run in any AioContext.
> > "can run in any AioContext" makes me wonder what the exact requirements
> > are. Can they run in any*thread* (regardless of whether an AioContext
> > even exists for that thread) or do they need to run in a thread that has
> > called qemu_set_current_aio_context()?
>
> I think they can run in any thread as long as they have called
> aio_context_acquire/release; later on, they will be able to run in any
> thread completely (which will be the underlying mechanism for multiqueue).
Great, it would be good to reflect this in the comment.
Stefan
signature.asc
Description: PGP signature
- [RFC PATCH 0/4] block layer: split block APIs in graph and I/O, Emanuele Giuseppe Esposito, 2021/09/08
- [RFC PATCH 2/4] migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread, Emanuele Giuseppe Esposito, 2021/09/08
- [RFC PATCH 1/4] main-loop.h: introduce qemu_in_main_thread(), Emanuele Giuseppe Esposito, 2021/09/08
- [RFC PATCH 4/4] block/block-backend.c: assertions for block-backend, Emanuele Giuseppe Esposito, 2021/09/08
- [RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O and graph API, Emanuele Giuseppe Esposito, 2021/09/08
- Re: [RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O and graph API, Stefan Hajnoczi, 2021/09/13
- Re: [RFC PATCH 0/4] block layer: split block APIs in graph and I/O, Stefan Hajnoczi, 2021/09/13
Re: [RFC PATCH 0/4] block layer: split block APIs in graph and I/O, Stefan Hajnoczi, 2021/09/13