[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/nvme: fix validation of ASQ and ACQ
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH] hw/nvme: fix validation of ASQ and ACQ |
|
Date: |
Mon, 23 Aug 2021 19:47:48 -0600 |
On Mon, Aug 23, 2021 at 02:20:18PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Address 0x0 is a valid address. Fix the admin submission and completion
> queue address validation to not error out on this.
Indeed, there are environments that can use that address. It's a host error if
the controller was enabled with invalid queue addresses anyway. The controller
only needs to verify the lower bits are clear, which we do later.
Reviewed-by: Keith Busch <kbusch@kernel.org>