qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 20/33] block/block-copy: make setting progress optional


From: Hanna Reitz
Subject: Re: [PATCH v7 20/33] block/block-copy: make setting progress optional
Date: Tue, 10 Aug 2021 17:23:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 04.08.21 11:38, Vladimir Sementsov-Ogievskiy wrote:
Now block-copy will crash if user don't set progress meter by
block_copy_set_progress_meter(). copy-before-write filter will be used
in separate of backup job, and it doesn't want any progress meter (for
now). So, allow not setting it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
  block/block-copy.c | 18 +++++++++++-------
  1 file changed, 11 insertions(+), 7 deletions(-)

(Sorry for the accidental reply to v2...  I’ll just repeat myself:)

OK, looks a bit different from when I last reviewed this, because of the rebase on e3dd339feec2da3bcd82021e4ce4fe09dbf9c8b4, but R-b stands.

Hanna




reply via email to

[Prev in Thread] Current Thread [Next in Thread]