[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.1? v2 2/7] mirror: Drop s->synced
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH for-6.1? v2 2/7] mirror: Drop s->synced |
|
Date: |
Mon, 26 Jul 2021 10:26:23 -0500 |
|
User-agent: |
NeoMutt/20210205-647-5d4e008 |
On Mon, Jul 26, 2021 at 04:46:08PM +0200, Max Reitz wrote:
> As of HEAD^, there is no meaning to s->synced other than whether the job
> is READY or not. job_is_ready() gives us that information, too.
>
> Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/mirror.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH for-6.1? v2 0/7] mirror: Handle errors after READY cancel, Max Reitz, 2021/07/26
- [PATCH for-6.1? v2 1/7] mirror: Keep s->synced on error, Max Reitz, 2021/07/26
- [PATCH for-6.1? v2 2/7] mirror: Drop s->synced, Max Reitz, 2021/07/26
- [PATCH for-6.1? v2 4/7] jobs: Give Job.force_cancel more meaning, Max Reitz, 2021/07/26
- [PATCH for-6.1? v2 3/7] job: @force parameter for job_cancel_sync{, _all}(), Max Reitz, 2021/07/26
- [PATCH for-6.1? v2 5/7] job: Add job_cancel_requested(), Max Reitz, 2021/07/26
- [PATCH for-6.1? v2 6/7] mirror: Check job_is_cancelled() earlier, Max Reitz, 2021/07/26