[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 2/6] block/rbd: store object_size in BDRVRBDState
From: |
Ilya Dryomov |
Subject: |
[PATCH v5 2/6] block/rbd: store object_size in BDRVRBDState |
Date: |
Fri, 2 Jul 2021 19:23:52 +0200 |
From: Peter Lieven <pl@kamp.de>
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
---
block/rbd.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index b4b928bbb99f..1ebf8f7e4875 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -102,6 +102,7 @@ typedef struct BDRVRBDState {
char *snap;
char *namespace;
uint64_t image_size;
+ uint64_t object_size;
} BDRVRBDState;
static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
@@ -958,6 +959,7 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict
*options, int flags,
const QDictEntry *e;
Error *local_err = NULL;
char *keypairs, *secretid;
+ rbd_image_info_t info;
int r;
keypairs = g_strdup(qdict_get_try_str(options, "=keyvalue-pairs"));
@@ -1035,12 +1037,14 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict
*options, int flags,
#endif
}
- r = rbd_get_size(s->image, &s->image_size);
+ r = rbd_stat(s->image, &info, sizeof(info));
if (r < 0) {
- error_setg_errno(errp, -r, "error getting image size from %s",
+ error_setg_errno(errp, -r, "error getting image info from %s",
s->image_name);
goto failed_post_open;
}
+ s->image_size = info.size;
+ s->object_size = info.obj_size;
/* If we are using an rbd snapshot, we must be r/o, otherwise
* leave as-is */
@@ -1253,15 +1257,7 @@ static BlockAIOCB *qemu_rbd_aio_flush(BlockDriverState
*bs,
static int qemu_rbd_getinfo(BlockDriverState *bs, BlockDriverInfo *bdi)
{
BDRVRBDState *s = bs->opaque;
- rbd_image_info_t info;
- int r;
-
- r = rbd_stat(s->image, &info, sizeof(info));
- if (r < 0) {
- return r;
- }
-
- bdi->cluster_size = info.obj_size;
+ bdi->cluster_size = s->object_size;
return 0;
}
--
2.19.2
- [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Ilya Dryomov, 2021/07/02
- [PATCH v5 3/6] block/rbd: update s->image_size in qemu_rbd_getlength, Ilya Dryomov, 2021/07/02
- [PATCH v5 2/6] block/rbd: store object_size in BDRVRBDState,
Ilya Dryomov <=
- [PATCH v5 1/6] block/rbd: bump librbd requirement to luminous release, Ilya Dryomov, 2021/07/02
- [PATCH v5 6/6] block/rbd: drop qemu_rbd_refresh_limits, Ilya Dryomov, 2021/07/02
- [PATCH v5 4/6] block/rbd: migrate from aio to coroutines, Ilya Dryomov, 2021/07/02
- [PATCH v5 5/6] block/rbd: add write zeroes support, Ilya Dryomov, 2021/07/02
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Ilya Dryomov, 2021/07/02
- Re: [PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support, Kevin Wolf, 2021/07/06