[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] util/uri: do not check argument of uri_free()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/1] util/uri: do not check argument of uri_free() |
|
Date: |
Tue, 29 Jun 2021 06:34:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 6/28/21 11:55 PM, Heinrich Schuchardt wrote:
> uri_free() checks if its argument is NULL in uri_clean() and g_free().
> There is no need to check the argument before the call.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> block/nfs.c | 4 +---
> block/ssh.c | 4 +---
> capstone | 2 +-
> util/uri.c | 22 ++++++----------------
> 4 files changed, 9 insertions(+), 23 deletions(-)
Looks good ...
> diff --git a/capstone b/capstone
> index f8b1b83301..31254f17e3 160000
> --- a/capstone
> +++ b/capstone
> @@ -1 +1 @@
> -Subproject commit f8b1b833015a4ae47110ed068e0deb7106ced66d
> +Subproject commit 31254f17e3c6025f3465d1c974a8c96e338ddbe0
... except this change.