qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 28/33] nbd/client-connection: do qio_channel_set_delay(fal


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v3 28/33] nbd/client-connection: do qio_channel_set_delay(false)
Date: Fri, 4 Jun 2021 08:32:23 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

03.06.2021 23:48, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:09:06AM +0300, Vladimir Sementsov-Ogievskiy wrote:
nbd_open() does it (through nbd_establish_connection()).
Actually we lost that call on reconnect path in 1dc4718d849e1a1fe
"block/nbd: use non-blocking connect: fix vm hang on connect()"
when we have introduced reconnect thread.

s/have introduced/introduced the/


Fixes: 1dc4718d849e1a1fe665ce5241ed79048cfa2cfc
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
  nbd/client-connection.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/nbd/client-connection.c b/nbd/client-connection.c
index 36d2c7c693..00efff293f 100644
--- a/nbd/client-connection.c
+++ b/nbd/client-connection.c
@@ -126,6 +126,8 @@ static int nbd_connect(QIOChannelSocket *sioc, 
SocketAddress *addr,
          return ret;
      }
+ qio_channel_set_delay(QIO_CHANNEL(sioc), false);
+
      if (!info) {
          return 0;
      }

Reviewed-by: Eric Blake <eblake@redhat.com>

Is this bug fix something that can be cherry-picked in isolation, or
does it depend too much on the rest of the series?


Will try to move to start of the series

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]