Re: [PATCH v3 27/33] block/nbd: split nbd_co_do_establish_connection out of nbd_reconnect_attempt

[Vladimir Sementsov-Ogievskiy]

03.06.2021 23:04, Eric Blake wrote:
> On Fri, Apr 16, 2021 at 11:09:05AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Split out part, that we want to reuse for nbd_open().
>
> Split out the part that we want to reuse for nbd_open().
>
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >   block/nbd.c | 79 +++++++++++++++++++++++++++--------------------------
> >   1 file changed, 41 insertions(+), 38 deletions(-)
> >
> > diff --git a/block/nbd.c b/block/nbd.c
> > index 15b5921725..59971bfba8 100644
> > --- a/block/nbd.c
> > +++ b/block/nbd.c
> > @@ -361,11 +361,49 @@ static int nbd_handle_updated_info(BlockDriverState *bs, 
> > Error **errp)
> >       return 0;
> >   }
> >   
> > -static coroutine_fn void nbd_reconnect_attempt(BDRVNBDState *s)
> > +static int nbd_co_do_establish_connection(BlockDriverState *bs, Error **errp)
>
> Given the _co_ in the name, don't you need a coroutine_fn marker?

Yes, strange that I've dropped it

> Otherwise looks sane.


--
Best regards,
Vladimir