Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept socket

[John Snow]

On 6/3/21 4:06 AM, Emanuele Giuseppe Esposito wrote:
> On 03/06/2021 01:23, John Snow wrote:
> > On 5/20/21 3:52 AM, Emanuele Giuseppe Esposito wrote:
> > > Alsp add a new _qmp_timer field to the QEMUMachine class.
> > >
> > > Let's change the default socket timeout to None, so that if
> > > a subclass needs to add a timer, it can be done by modifying
> > > this private field.
> > >
> > > At the same time, restore the timer to be 15 seconds in iotests.py, to
> > > give an upper bound to qemu-iotests execution.
> > >
> > > Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> >
> > Hi Emanuele: I'm sorry, but with the recent Python PR this no longer 
> > applies to origin/master -- the python files got shuffled around a bit 
> > when I added the new CI tests.
> >
> > May I please ask you to rebase? You don't have to re-spin just yet, 
> > just pointing me to the rebase would help me out.
>
> Hi John, no problem. I rebased here:
> https://gitlab.com/eesposit/qemu/-/commits/qemu_iotests_io
>
> Let me know if I need to do anything else.
> I will re-spin later today.
>
> Thank you,
> Emanuele

Hi Emanuele:

https://gitlab.com/jsnow/qemu/-/commits/review

I added in a pylint ignore for you and these patches are clean now.

--js