[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 18/25] python/qemu: add isort to pipenv
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH v6 18/25] python/qemu: add isort to pipenv |
|
Date: |
Tue, 25 May 2021 16:34:24 -0400 |
On Tue, May 25, 2021 at 01:21:25PM -0400, John Snow wrote:
> On 5/25/21 11:56 AM, Cleber Rosa wrote:
> > On Wed, May 12, 2021 at 07:12:34PM -0400, John Snow wrote:
> > > isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret
> > > certain "from ..." clauses that are not related to imports.
> > >
> > > isort < 5.1.1 has a bug where it does not handle comments near import
> > > statements correctly.
> > >
> > > Require 5.1.2 or greater.
> > >
> > > isort can be run with 'isort -c qemu' from the python root.
> > >
> > > Signed-off-by: John Snow <jsnow@redhat.com>
> > > ---
> > > python/Pipfile | 1 +
> > > python/Pipfile.lock | 4 ++--
> > > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Cleber Rosa <crosa@redhat.com>
> >
>
> Thanks. I have also updated the commit message a little bit:
>
> isort can be run (in "check" mode) with 'isort -c qemu' from the python
> root. isort can also be used to fix/rewrite import order automatically
> by using 'isort qemu'.
>
> --js
OK, sounds even better!
- Cleber.
signature.asc
Description: PGP signature
- Re: [PATCH v6 13/25] python: add excluded dirs to flake8 config, (continued)
- [PATCH v6 14/25] python: Add flake8 to pipenv, John Snow, 2021/05/12
- [PATCH v6 15/25] python: move mypy.ini into setup.cfg, John Snow, 2021/05/12
- [PATCH v6 16/25] python: add mypy to pipenv, John Snow, 2021/05/12
- [PATCH v6 17/25] python: move .isort.cfg into setup.cfg, John Snow, 2021/05/12
- [PATCH v6 18/25] python/qemu: add isort to pipenv, John Snow, 2021/05/12
- [PATCH v6 19/25] python/qemu: add qemu package itself to pipenv, John Snow, 2021/05/12
- [PATCH v6 20/25] python: add devel package requirements to setuptools, John Snow, 2021/05/12
[PATCH v6 21/25] python: add avocado-framework and tests, John Snow, 2021/05/12
[PATCH v6 22/25] python: add Makefile for some common tasks, John Snow, 2021/05/12