[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 09/25] python: add pylint import exceptions
From: |
John Snow |
Subject: |
[PATCH v6 09/25] python: add pylint import exceptions |
Date: |
Wed, 12 May 2021 19:12:25 -0400 |
Pylint 2.5.x - 2.7.x have regressions that make import checking
inconsistent, see:
https://github.com/PyCQA/pylint/issues/3609
https://github.com/PyCQA/pylint/issues/3624
https://github.com/PyCQA/pylint/issues/3651
Pinning to 2.4.4 is worse, because it mandates versions of shared
dependencies that are too old for features we want in isort and mypy.
Oh well.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
python/qemu/machine/__init__.py | 3 +++
python/qemu/machine/machine.py | 2 +-
python/qemu/machine/qtest.py | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/qemu/machine/__init__.py b/python/qemu/machine/__init__.py
index 98302ea31e7..728f27adbed 100644
--- a/python/qemu/machine/__init__.py
+++ b/python/qemu/machine/__init__.py
@@ -22,6 +22,9 @@
# the COPYING file in the top-level directory.
#
+# pylint: disable=import-error
+# see: https://github.com/PyCQA/pylint/issues/3624
+# see: https://github.com/PyCQA/pylint/issues/3651
from .machine import QEMUMachine
from .qtest import QEMUQtestMachine, QEMUQtestProtocol
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index dea343afeba..6fe41d83cb5 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -38,7 +38,7 @@
Type,
)
-from qemu.qmp import (
+from qemu.qmp import ( # pylint: disable=import-error
QEMUMonitorProtocol,
QMPMessage,
QMPReturnValue,
diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
index 53926e434a7..c3adf4e3012 100644
--- a/python/qemu/machine/qtest.py
+++ b/python/qemu/machine/qtest.py
@@ -26,7 +26,7 @@
TextIO,
)
-from qemu.qmp import SocketAddrT
+from qemu.qmp import SocketAddrT # pylint: disable=import-error
from .machine import QEMUMachine
--
2.30.2
- Re: [PATCH v6 04/25] python: add qemu package installer, (continued)
- [PATCH v6 09/25] python: add pylint import exceptions,
John Snow <=
- [PATCH v6 10/25] python: move pylintrc into setup.cfg, John Snow, 2021/05/12
- [PATCH v6 08/25] python: Add pipenv support, John Snow, 2021/05/12
- [PATCH v6 11/25] python: add pylint to pipenv, John Snow, 2021/05/12
- [PATCH v6 12/25] python: move flake8 config to setup.cfg, John Snow, 2021/05/12
- [PATCH v6 13/25] python: add excluded dirs to flake8 config, John Snow, 2021/05/12
- [PATCH v6 14/25] python: Add flake8 to pipenv, John Snow, 2021/05/12
- [PATCH v6 15/25] python: move mypy.ini into setup.cfg, John Snow, 2021/05/12