Re: [PATCH v2 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

[BALATON Zoltan]

On Tue, 11 May 2021, Philippe Mathieu-Daudé wrote:
> The motivation behind this series is to remove the
> isa_get_irq(NULL) call to simplify the ISA generic model.
>
> Since v1:
> - rebased on top of remotes/dg-gitlab/tags/ppc-for-6.1-20210504

I'll try to have a look at these later but some notes: The pegasos2 
changes are now in master so if this was before that maybe rebasing on 
master is now enough. However I wonder if any changes to pegasos2.c is 
needed due to changed init of the chip model or is that only affecting 
82c686b? Please also note that pegasos2 is not enabled by default due to 
needing undistributable firmware ROM so to test it you need to enable it 
in default-configs/devices/ppc-softmmu.mak

Regards,
BALATON Zoltan

> Philippe Mathieu-Daudé (6):
>  hw/isa/vt82c686: Name output IRQ as 'intr'
>  hw/isa/vt82c686: Simplify removing unuseful qemu_allocate_irqs() call
>  hw/isa/vt82c686: Let ISA function expose ISA IRQs
>  hw/ide/via: Replace magic 2 value by ARRAY_SIZE / MAX_IDE_DEVS
>  hw/ide/via: Connect IDE function output IRQs to the ISA function input
>  hw/southbridge/vt82c686: Introduce VT82C686B_SOUTHBRIDGE
>
> hw/ide/via.c               |  31 ++++++++---
> hw/isa/vt82c686.c          |  27 +++++-----
> hw/mips/fuloong2e.c        |  35 +++---------
> hw/southbridge/vt82c686.c  | 107 +++++++++++++++++++++++++++++++++++++
> MAINTAINERS                |   1 +
> hw/Kconfig                 |   1 +
> hw/isa/Kconfig             |   9 ----
> hw/meson.build             |   1 +
> hw/southbridge/Kconfig     |   8 +++
> hw/southbridge/meson.build |   1 +
> 10 files changed, 164 insertions(+), 57 deletions(-)
> create mode 100644 hw/southbridge/vt82c686.c
> create mode 100644 hw/southbridge/Kconfig
> create mode 100644 hw/southbridge/meson.build
>
> --
> 2.26.3