[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/23] hw/block/dataplane/virtio-blk: Avoid dynamic stack all
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 06/23] hw/block/dataplane/virtio-blk: Avoid dynamic stack allocation |
|
Date: |
Thu, 6 May 2021 09:53:14 +0100 |
On Wed, May 05, 2021 at 11:10:30PM +0200, Philippe Mathieu-Daudé wrote:
> Use autofree heap allocation instead of variable-length
> array on the stack.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/block/dataplane/virtio-blk.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Why? This is a performance-critical code path and BITS_TO_LONGS(nvqs) is
small.
Stefan
signature.asc
Description: PGP signature
- [PATCH 03/23] chardev/baum: Use definitions to avoid dynamic stack allocation, (continued)
[PATCH 07/23] hw/block/nvme: Use definition to avoid dynamic stack allocation, Philippe Mathieu-Daudé, 2021/05/05