Re: [PATCH v2 1/9] block/write-threshold: don't use write notifiers

[Vladimir Sementsov-Ogievskiy]

05.05.2021 15:37, Max Reitz wrote:
> > write-notifiers are used only for write-threshold. New code for such
> > purpose should create filters.
> >
> > Let's better special-case write-threshold and drop write notifiers at
> > all. (Actually, write-threshold is special-cased anyway, as the only
> > user of write-notifiers)
>
> Not noted here: That write-threshold.c is also reorganized.  (Doesn’t seem 
> entirely necessary to do right in this patch, but why not.)

You mean, we probably could only add new interface here, keeping other things 
as is, and drop them in a separate patch?

If keep as is we can add the following here:

  So, create a new direct interface for bdrv_co_write_req_prepare() and drop
  all write-notifier related logic from write-threshold.c.

--
Best regards,
Vladimir