[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/7] usb/dev-mtp: use GDateTime for formatting timestamp for obje
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 4/7] usb/dev-mtp: use GDateTime for formatting timestamp for objects |
Date: |
Wed, 5 May 2021 11:36:59 +0100 |
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
hw/usb/dev-mtp.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index bbb8274344..a71fcc326d 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -772,12 +772,9 @@ static void usb_mtp_add_str(MTPData *data, const char *str)
static void usb_mtp_add_time(MTPData *data, time_t time)
{
- char buf[16];
- struct tm tm;
-
- gmtime_r(&time, &tm);
- strftime(buf, sizeof(buf), "%Y%m%dT%H%M%S", &tm);
- usb_mtp_add_str(data, buf);
+ g_autoptr(GDateTime) then = g_date_time_new_from_unix_utc(time);
+ g_autofree char *thenstr = g_date_time_format(then, "%Y%m%dT%H%M%S");
+ usb_mtp_add_str(data, thenstr);
}
/* ----------------------------------------------------------------------- */
--
2.31.1
- [PATCH 0/7] replace all use of strftime() with g_date_time_format(), Daniel P . Berrangé, 2021/05/05
- [PATCH 1/7] migration: use GDateTime for formatting timestamp in snapshot names, Daniel P . Berrangé, 2021/05/05
- [PATCH 2/7] block: use GDateTime for formatting timestamp when dumping snapshot info, Daniel P . Berrangé, 2021/05/05
- [PATCH 3/7] net/rocker: use GDateTime for formatting timestamp in debug messages, Daniel P . Berrangé, 2021/05/05
- [PATCH 4/7] usb/dev-mtp: use GDateTime for formatting timestamp for objects,
Daniel P . Berrangé <=
- [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers, Daniel P . Berrangé, 2021/05/05
- [PATCH 6/7] linux-user: use GDateTime for formatting timestamp for core file, Daniel P . Berrangé, 2021/05/05
- [PATCH 7/7] virtiofsd: use GDateTime for formatting timestamp for debug messages, Daniel P . Berrangé, 2021/05/05