[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/8] block: add a few more notes on locking
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v2 5/8] block: add a few more notes on locking |
Date: |
Wed, 5 May 2021 10:53:29 +0100 |
On Mon, Apr 19, 2021 at 10:55:38AM +0200, Emanuele Giuseppe Esposito wrote:
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> include/block/block_int.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/block/block_int.h b/include/block/block_int.h
> index a1aad5ad2d..67a0777e12 100644
> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -154,7 +154,9 @@ struct BlockDriver {
> */
> bool supports_backing;
>
> - /* For handling image reopen for split or non-split files */
> + /* For handling image reopen for split or non-split files. Called
> + * with no I/O pending.
Does "Called with no I/O pending" mean "Called in a drained section"?
> + */
> int (*bdrv_reopen_prepare)(BDRVReopenState *reopen_state,
> BlockReopenQueue *queue, Error **errp);
> void (*bdrv_reopen_commit)(BDRVReopenState *reopen_state);
> @@ -168,6 +170,7 @@ struct BlockDriver {
> /* Protocol drivers should implement this instead of bdrv_open */
> int (*bdrv_file_open)(BlockDriverState *bs, QDict *options, int flags,
> Error **errp);
> + /* Called from main thread. */
> void (*bdrv_close)(BlockDriverState *bs);
>
>
> --
> 2.30.2
>
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 5/8] block: add a few more notes on locking,
Stefan Hajnoczi <=