[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/cli
From: |
Roman Kagan |
Subject: |
Re: [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection |
Date: |
Thu, 8 Apr 2021 20:04:55 +0300 |
On Thu, Apr 08, 2021 at 05:08:27PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We now have bs-independent connection API, which consists of four
> functions:
>
> nbd_client_connection_new()
> nbd_client_connection_unref()
> nbd_co_establish_connection()
> nbd_co_establish_connection_cancel()
>
> Move them to a separate file together with NBDClientConnection
> structure which becomes private to the new API.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> Hmm. I keep only Virtuozzo's copyright in a new file, as actually I've
> developed nbd-reconnection code. Still probably safer to save all
> copyrights. Let me now if you think so and I'll add them.
Not my call.
> include/block/nbd.h | 11 +++
> block/nbd.c | 167 ----------------------------------
> nbd/client-connection.c | 192 ++++++++++++++++++++++++++++++++++++++++
> nbd/meson.build | 1 +
> 4 files changed, 204 insertions(+), 167 deletions(-)
> create mode 100644 nbd/client-connection.c
Reviewed-by: Roman Kagan <rvkagan@yandex-team.ru>
- Re: [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConnection, (continued)
- [PATCH v2 05/10] block/nbd: drop thr->state, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 02/10] block/nbd: BDRVNBDState: drop unused connect_err and connect_status, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 07/10] block/nbd: make nbd_co_establish_connection_cancel() bs-independent, Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 09/10] block/nbd: introduce nbd_client_connection_new(), Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection, Vladimir Sementsov-Ogievskiy, 2021/04/08
- Re: [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection,
Roman Kagan <=
- [PATCH v2 06/10] block/nbd: bs-independent interface for nbd_co_establish_connection(), Vladimir Sementsov-Ogievskiy, 2021/04/08
- [PATCH v2 03/10] util/async: aio_co_enter(): do aio_co_schedule in general case, Vladimir Sementsov-Ogievskiy, 2021/04/08
- Re: [PATCH v2 00/10] block/nbd: move connection code to separate file, Roman Kagan, 2021/04/08