[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 11/14] block/nbd: refactor connect_bh()
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH 11/14] block/nbd: refactor connect_bh() |
Date: |
Wed, 7 Apr 2021 13:46:34 +0300 |
Now it's just a wrapper for aio_co_wake(). Make it more obvious.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block/nbd.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 29bdbd38b6..6729561935 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -362,11 +362,9 @@ static void nbd_init_connect_thread(BlockDriverState *bs)
qemu_mutex_init(&s->connect_thread->mutex);
}
-static void connect_bh(void *opaque)
+static void coroutine_wake_bh(void *opaque)
{
- BDRVNBDState *state = opaque;
-
- aio_co_wake(state->connection_co);
+ aio_co_wake(opaque);
}
static void connect_thread_cb(QIOChannelSocket *sioc, int ret, void *opaque)
@@ -403,7 +401,8 @@ static void connect_thread_cb(QIOChannelSocket *sioc, int
ret, void *opaque)
* Direct call to aio_co_wake() from thread context works bad. So use
* aio_bh_schedule_oneshot() as a mediator.
*/
- aio_bh_schedule_oneshot(bdrv_get_aio_context(thr->bs), connect_bh, s);
+ aio_bh_schedule_oneshot(bdrv_get_aio_context(thr->bs),
+ coroutine_wake_bh, s->connection_co);
}
if (do_free) {
--
2.29.2
- [PATCH 04/14] block/nbd: split connect_thread_cb() out of connect_thread_func(), (continued)
- [PATCH 04/14] block/nbd: split connect_thread_cb() out of connect_thread_func(), Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 06/14] block/nbd: further segregation of connect-thread, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 02/14] block/nbd: nbd_co_establish_connection(): drop unused errp, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 05/14] block/nbd: rename NBDConnectThread to NBDConnectCB, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 08/14] block/nbd: move nbd connect-thread to nbd/client-connect.c, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 07/14] block/nbd: drop nbd_free_connect_thread(), Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 09/14] block/nbd: NBDConnectCB: drop bh_* fields, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 10/14] block/nbd: move wait_connect field under mutex protection, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 11/14] block/nbd: refactor connect_bh(),
Vladimir Sementsov-Ogievskiy <=
- [PATCH 12/14] block/nbd: refactor nbd_co_establish_connection, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 13/14] block/nbd: nbd_co_establish_connection_cancel(): rename wake to do_wake, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 14/14] block/nbd: drop thr->state, Vladimir Sementsov-Ogievskiy, 2021/04/07
- DROP THIS Re: [PATCH 00/14] nbd: move reconnect-thread to separate file, Vladimir Sementsov-Ogievskiy, 2021/04/08