[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/14] block/nbd: rename NBDConnectThread to NBDConnectCB
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH 05/14] block/nbd: rename NBDConnectThread to NBDConnectCB |
Date: |
Wed, 7 Apr 2021 13:46:28 +0300 |
Now it's mostly a state of call-back, so rename the structure, cleaning
the way for new small NBDConnectThread.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block/nbd.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index a9d351cbbc..e16c6d636a 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -84,7 +84,7 @@ typedef enum NBDConnectThreadState {
CONNECT_THREAD_SUCCESS
} NBDConnectThreadState;
-typedef struct NBDConnectThread {
+typedef struct NBDConnectCB {
/* Initialization constants */
SocketAddress *saddr; /* address to connect to */
/*
@@ -101,7 +101,7 @@ typedef struct NBDConnectThread {
QemuMutex mutex;
NBDConnectThreadState state; /* current state of the thread */
AioContext *bh_ctx; /* where to schedule bh (NULL means don't schedule) */
-} NBDConnectThread;
+} NBDConnectCB;
typedef struct BDRVNBDState {
QIOChannelSocket *sioc; /* The master data channel */
@@ -136,7 +136,7 @@ typedef struct BDRVNBDState {
bool alloc_depth;
bool wait_connect;
- NBDConnectThread *connect_thread;
+ NBDConnectCB *connect_thread;
} BDRVNBDState;
static int nbd_establish_connection(BlockDriverState *bs, SocketAddress *saddr,
@@ -364,9 +364,9 @@ static void connect_bh(void *opaque)
static void nbd_init_connect_thread(BDRVNBDState *s)
{
- s->connect_thread = g_new(NBDConnectThread, 1);
+ s->connect_thread = g_new(NBDConnectCB, 1);
- *s->connect_thread = (NBDConnectThread) {
+ *s->connect_thread = (NBDConnectCB) {
.saddr = QAPI_CLONE(SocketAddress, s->saddr),
.state = CONNECT_THREAD_NONE,
.bh_func = connect_bh,
@@ -376,7 +376,7 @@ static void nbd_init_connect_thread(BDRVNBDState *s)
qemu_mutex_init(&s->connect_thread->mutex);
}
-static void nbd_free_connect_thread(NBDConnectThread *thr)
+static void nbd_free_connect_thread(NBDConnectCB *thr)
{
if (thr->sioc) {
qio_channel_close(QIO_CHANNEL(thr->sioc), NULL);
@@ -387,7 +387,7 @@ static void nbd_free_connect_thread(NBDConnectThread *thr)
static void connect_thread_cb(int ret, void *opaque)
{
- NBDConnectThread *thr = opaque;
+ NBDConnectCB *thr = opaque;
bool do_free = false;
qemu_mutex_lock(&thr->mutex);
@@ -418,7 +418,7 @@ static void connect_thread_cb(int ret, void *opaque)
static void *connect_thread_func(void *opaque)
{
- NBDConnectThread *thr = opaque;
+ NBDConnectCB *thr = opaque;
int ret;
thr->sioc = qio_channel_socket_new();
@@ -440,7 +440,7 @@ nbd_co_establish_connection(BlockDriverState *bs)
int ret;
QemuThread thread;
BDRVNBDState *s = bs->opaque;
- NBDConnectThread *thr = s->connect_thread;
+ NBDConnectCB *thr = s->connect_thread;
qemu_mutex_lock(&thr->mutex);
@@ -536,7 +536,7 @@ static void
nbd_co_establish_connection_cancel(BlockDriverState *bs,
bool detach)
{
BDRVNBDState *s = bs->opaque;
- NBDConnectThread *thr = s->connect_thread;
+ NBDConnectCB *thr = s->connect_thread;
bool wake = false;
bool do_free = false;
--
2.29.2
- [PATCH 01/14] block/nbd: BDRVNBDState: drop unused connect_err, (continued)
- [PATCH 01/14] block/nbd: BDRVNBDState: drop unused connect_err, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 03/14] block/nbd: drop unused NBDConnectThread::err field, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 04/14] block/nbd: split connect_thread_cb() out of connect_thread_func(), Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 06/14] block/nbd: further segregation of connect-thread, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 02/14] block/nbd: nbd_co_establish_connection(): drop unused errp, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 05/14] block/nbd: rename NBDConnectThread to NBDConnectCB,
Vladimir Sementsov-Ogievskiy <=
- [PATCH 08/14] block/nbd: move nbd connect-thread to nbd/client-connect.c, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 07/14] block/nbd: drop nbd_free_connect_thread(), Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 09/14] block/nbd: NBDConnectCB: drop bh_* fields, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 10/14] block/nbd: move wait_connect field under mutex protection, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 11/14] block/nbd: refactor connect_bh(), Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 12/14] block/nbd: refactor nbd_co_establish_connection, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 13/14] block/nbd: nbd_co_establish_connection_cancel(): rename wake to do_wake, Vladimir Sementsov-Ogievskiy, 2021/04/07
- [PATCH 14/14] block/nbd: drop thr->state, Vladimir Sementsov-Ogievskiy, 2021/04/07
- DROP THIS Re: [PATCH 00/14] nbd: move reconnect-thread to separate file, Vladimir Sementsov-Ogievskiy, 2021/04/08