Re: [PATCH] hw/block/nvme: remove description for zoned.append_size_limit

[Klaus Jensen]

On Mar 30 10:19, Niklas Cassel wrote:
> On Tue, Mar 23, 2021 at 12:20:32PM +0100, Klaus Jensen wrote:
> > On Mar 23 11:18, Niklas Cassel wrote:
> > > From: Niklas Cassel <niklas.cassel@wdc.com>
> > > 
> > > The description was originally removed in commit 578d914b263c
> > > ("hw/block/nvme: align zoned.zasl with mdts") together with the removal
> > > of the zoned.append_size_limit parameter itself.
> > > 
> > > However, it was (most likely accidentally), re-added in commit
> > > f7dcd31885cb ("hw/block/nvme: add non-mdts command size limit for 
> > > verify").
> > > 
> > > Remove the description again, since the parameter it describes,
> > > zoned.append_size_limit, no longer exists.
> > > 
> > > Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> > > ---
> > >  hw/block/nvme.c | 8 --------
> > >  1 file changed, 8 deletions(-)
> > > 
> > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> > > index 6842b01ab5..205d3ec944 100644
> > > --- a/hw/block/nvme.c
> > > +++ b/hw/block/nvme.c
> > > @@ -91,14 +91,6 @@
> > >   *   the minimum memory page size (CAP.MPSMIN). The default value is 0 
> > > (i.e.
> > >   *   defaulting to the value of `mdts`).
> > >   *
> > > - * - `zoned.append_size_limit`
> > > - *   The maximum I/O size in bytes that is allowed in Zone Append 
> > > command.
> > > - *   The default is 128KiB. Since internally this this value is 
> > > maintained as
> > > - *   ZASL = log2(<maximum append size> / <page size>), some values 
> > > assigned
> > > - *   to this property may be rounded down and result in a lower maximum 
> > > ZA
> > > - *   data size being in effect. By setting this property to 0, users can 
> > > make
> > > - *   ZASL to be equal to MDTS. This property only affects zoned 
> > > namespaces.
> > > - *
> > >   * nvme namespace device parameters
> > >   * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >   * - `subsys`
> > > -- 
> > > 2.30.2
> > 
> > Argh. Thanks Niklas, queing it up for fixes.
> > 
> > Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> 
> I don't see it in nvme-fixes yet.
> 
> Did it get stuck in purgatory? ;)
> 
> 

I could have included it for the PULL from yesterday, but I kinda forgot
and only added the coverity fixes. That's pulled now, so I've queued it
up for the next round of fixes now! :)

Thanks for following up on it!

signature.asc
Description: PGP signature