qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/5] qemu-iotests: allow passing unittest.main arguments t


From: Paolo Bonzini
Subject: Re: [PATCH v2 2/5] qemu-iotests: allow passing unittest.main arguments to the test scripts
Date: Tue, 23 Mar 2021 22:22:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 23/03/21 20:17, Vladimir Sementsov-Ogievskiy wrote:

+    unittest.main(argv=argv,
+                  testRunner=ReproducibleTestRunner,
+                  verbosity=2 if debug else 1,
+                  warnings=None if sys.warnoptions else 'ignore')
  def execute_setup_common(supported_fmts: Sequence[str] = (),
                           supported_platforms: Sequence[str] = (),
@@ -1350,7 +1354,7 @@ def execute_test(*args, test_function=None, **kwargs):
      debug = execute_setup_common(*args, **kwargs)
      if not test_function:
-        execute_unittest(debug)
+        execute_unittest(sys.argv, debug)
      else:
          test_function()


If you decide to resend for some of my comments (or due to another reviewer be more careful), I think it would be nicer to merge part of this commit which moves us from passing object to passing ReproducibleTestRunner to the previous commit, to not remove line that we've added in the previous commit. And here only add argv argument.

Well, it's the price to pay to make the previous commit as independent as possible. In particular in the previous patch there's no reason to add the complexity of warnings.

I could make it three commits, but at some point too much splitting adds clutter, the patches are already pretty small.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]