Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device

[Paolo Bonzini]

On 08/03/21 13:22, Klaus Jensen wrote:
> This patch introduced a simple nvme-subsys device model.  The subsystem
> will be prepared with subsystem NQN with <subsys_id> provided in
> nvme-subsys device:
>
>    ex) -device nvme-subsys,id=subsys0: nqn.2019-08.org.qemu:subsys0

Hi Klaus, sorry for not spotting this before.  In the SCSI subsystem we 
moved away from using id as guest-visible data.  Keeping it as a default 
is fine I guess, but would it be possible to add an nqn property to 
nvme-subsys and use it if it is present instead of the id?

Thanks,

Paolo