[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/38] hw/block/nvme: pull write pointer advancement to separate f
From: |
Klaus Jensen |
Subject: |
[PULL 09/38] hw/block/nvme: pull write pointer advancement to separate function |
Date: |
Mon, 8 Mar 2021 13:22:44 +0100 |
From: Klaus Jensen <k.jensen@samsung.com>
In preparation for Simple Copy, pull write pointer advancement into a
separate function that is independent off an NvmeRequest.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
---
hw/block/nvme.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 9d85d498455c..4d6cd7755986 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1398,6 +1398,16 @@ static inline uint16_t nvme_zrm_open(NvmeNamespace *ns,
NvmeZone *zone)
return __nvme_zrm_open(ns, zone, false);
}
+static void __nvme_advance_zone_wp(NvmeNamespace *ns, NvmeZone *zone,
+ uint32_t nlb)
+{
+ zone->d.wp += nlb;
+
+ if (zone->d.wp == nvme_zone_wr_boundary(zone)) {
+ nvme_zrm_finish(ns, zone);
+ }
+}
+
static void nvme_finalize_zoned_write(NvmeNamespace *ns, NvmeRequest *req)
{
NvmeRwCmd *rw = (NvmeRwCmd *)&req->cmd;
@@ -1409,11 +1419,7 @@ static void nvme_finalize_zoned_write(NvmeNamespace *ns,
NvmeRequest *req)
nlb = le16_to_cpu(rw->nlb) + 1;
zone = nvme_get_zone_by_slba(ns, slba);
- zone->d.wp += nlb;
-
- if (zone->d.wp == nvme_zone_wr_boundary(zone)) {
- nvme_zrm_finish(ns, zone);
- }
+ __nvme_advance_zone_wp(ns, zone, nlb);
}
static inline bool nvme_is_write(NvmeRequest *req)
--
2.30.1
- Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device, (continued)
- [PULL 03/38] hw/block/nvme: add CMIC enum value for Identify Controller, Klaus Jensen, 2021/03/08
- [PULL 02/38] hw/block/nvme: support to map controller to a subsystem, Klaus Jensen, 2021/03/08
- [PULL 05/38] hw/block/nvme: add NMIC enum value for Identify Namespace, Klaus Jensen, 2021/03/08
- [PULL 04/38] hw/block/nvme: support for multi-controller in subsystem, Klaus Jensen, 2021/03/08
- [PULL 10/38] nvme: updated shared header for copy command, Klaus Jensen, 2021/03/08
- [PULL 06/38] hw/block/nvme: support for shared namespace in subsystem, Klaus Jensen, 2021/03/08
- [PULL 08/38] hw/block/nvme: refactor zone resource management, Klaus Jensen, 2021/03/08
- [PULL 07/38] hw/block/nvme: remove unused parameter in check zone write, Klaus Jensen, 2021/03/08
- [PULL 13/38] hw/block/nvme: add missing mor/mar constraint checks, Klaus Jensen, 2021/03/08
- [PULL 09/38] hw/block/nvme: pull write pointer advancement to separate function,
Klaus Jensen <=
- [PULL 11/38] hw/block/nvme: add simple copy command, Klaus Jensen, 2021/03/08
- [PULL 12/38] hw/block/nvme: fix Close Zone, Klaus Jensen, 2021/03/08
- [PULL 14/38] hw/block/nvme: improve invalid zasl value reporting, Klaus Jensen, 2021/03/08
- [PULL 15/38] hw/block/nvme: use locally assigned QEMU IEEE OUI, Klaus Jensen, 2021/03/08
- [PULL 16/38] hw/block/nvme: add broadcast nsid support flush command, Klaus Jensen, 2021/03/08
- [PULL 17/38] hw/block/nvme: document 'mdts' nvme device parameter, Klaus Jensen, 2021/03/08
- [PULL 18/38] hw/block/nvme: deduplicate bad mdts trace event, Klaus Jensen, 2021/03/08
- [PULL 20/38] hw/block/nvme: remove unnecessary endian conversion, Klaus Jensen, 2021/03/08
- [PULL 19/38] hw/block/nvme: align zoned.zasl with mdts, Klaus Jensen, 2021/03/08
- [PULL 28/38] hw/block/nvme: try to deal with the iov/qsg duality, Klaus Jensen, 2021/03/08