[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] storage-daemon: include current command line option i
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2 0/2] storage-daemon: include current command line option in the errors |
Date: |
Mon, 1 Mar 2021 19:24:08 +0100 |
Am 01.03.2021 um 16:28 hat Paolo Bonzini geschrieben:
> Use the location management facilities that the emulator uses, so that
> the current command line option appears in the error message.
>
> Before:
>
> $ storage-daemon/qemu-storage-daemon --nbd key..=
> qemu-storage-daemon: Invalid parameter 'key..'
>
> After:
>
> $ storage-daemon/qemu-storage-daemon --nbd key..=
> qemu-storage-daemon: --nbd key..=: Invalid parameter 'key..'
>
> The first patch tweaks the command line parsing so that argv is
> not reordered by getopt_long and optind is only advanced by one
> option+argument on every call to getopt_long. This is required
> by loc_set_cmdline.
Thanks, very useful to know about the "-" switch in getopts.
Applied to the block branch.
Kevin