[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 1/3] hw/pflash_cfi*: Replace DPRINTF with trace events
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [RFC PATCH v2 1/3] hw/pflash_cfi*: Replace DPRINTF with trace events |
|
Date: |
Mon, 22 Feb 2021 14:59:20 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/22/21 10:07 AM, David Edmondson wrote:
> Rather than having a device specific debug implementation in
> pflash_cfi01.c and pflash_cfi02.c, use the standard tracing facility.
>
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
> hw/block/pflash_cfi01.c | 78 +++++++++++++++++------------------------
> hw/block/pflash_cfi02.c | 75 +++++++++++++++------------------------
> hw/block/trace-events | 39 ++++++++++++++++-----
> 3 files changed, 91 insertions(+), 101 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>