[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 24/25] gitlab: add python linters to CI
From: |
John Snow |
Subject: |
[PATCH v5 24/25] gitlab: add python linters to CI |
Date: |
Thu, 18 Feb 2021 14:27:32 -0500 |
Add python3.6 to the fedora container image: we need it to run the
linters against that explicit version to make sure we don't break our
minimum version promise.
Add pipenv so that we can fetch precise versions of pip packages we need
to guarantee test reproducability.
Signed-off-by: John Snow <jsnow@redhat.com>
---
.gitlab-ci.yml | 10 ++++++++++
tests/docker/dockerfiles/fedora.docker | 2 ++
2 files changed, 12 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 7adb9a4cef0..8dc4de9b168 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -665,6 +665,16 @@ check-patch:
GIT_DEPTH: 1000
allow_failure: true
+
+check-python:
+ stage: build
+ image: $CI_REGISTRY_IMAGE/qemu/fedora:latest
+ script:
+ - cd python
+ - make venv-check
+ variables:
+ GIT_DEPTH: 1000
+
check-dco:
stage: build
image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
diff --git a/tests/docker/dockerfiles/fedora.docker
b/tests/docker/dockerfiles/fedora.docker
index 0d7602abbeb..1262b8c5e03 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -84,6 +84,7 @@ ENV PACKAGES \
numactl-devel \
perl \
perl-Test-Harness \
+ pipenv \
pixman-devel \
python3 \
python3-PyYAML \
@@ -93,6 +94,7 @@ ENV PACKAGES \
python3-pip \
python3-sphinx \
python3-virtualenv \
+ python3.6 \
rdma-core-devel \
SDL2-devel \
snappy-devel \
--
2.29.2
- [PATCH v5 12/25] python: move flake8 config to setup.cfg, (continued)
- [PATCH v5 12/25] python: move flake8 config to setup.cfg, John Snow, 2021/02/18
- [PATCH v5 09/25] python: add pylint import exceptions, John Snow, 2021/02/18
- [PATCH v5 11/25] python: add pylint to pipenv, John Snow, 2021/02/18
- [PATCH v5 14/25] python: Add flake8 to pipenv, John Snow, 2021/02/18
- [PATCH v5 15/25] python: move mypy.ini into setup.cfg, John Snow, 2021/02/18
- [PATCH v5 16/25] python: add mypy to pipenv, John Snow, 2021/02/18
- [PATCH v5 17/25] python: move .isort.cfg into setup.cfg, John Snow, 2021/02/18
- [PATCH v5 18/25] python/qemu: add isort to pipenv, John Snow, 2021/02/18
- [PATCH v5 19/25] python/qemu: add qemu package itself to pipenv, John Snow, 2021/02/18
- [PATCH v5 21/25] python: add pytest and tests, John Snow, 2021/02/18
- [PATCH v5 24/25] gitlab: add python linters to CI,
John Snow <=
- [PATCH v5 22/25] python: add Makefile for some common tasks, John Snow, 2021/02/18
- [PATCH v5 20/25] python: add devel package requirements to setuptools, John Snow, 2021/02/18
- [PATCH v5 25/25] python: add 'make develop' target, John Snow, 2021/02/18
- [PATCH v5 23/25] python: add .gitignore, John Snow, 2021/02/18