qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests: 30: drop from auto group (and effectively from make


From: Peter Maydell
Subject: Re: [PATCH] iotests: 30: drop from auto group (and effectively from make check)
Date: Fri, 5 Feb 2021 15:18:54 +0000

On Fri, 5 Feb 2021 at 14:48, Eric Blake <eblake@redhat.com> wrote:
>
> On 2/5/21 5:10 AM, Vladimir Sementsov-Ogievskiy wrote:
> > and trying to reproduce it on top of
> > "block: update graph permissions update" I had 634 successful
> > iterations
> > and then the following crash (which looks much better):
>
> This part of the commit message is odd - if we check it in to git as
> written, you're pointing to a future commit, while still stating that it
> is not a perfect commit.  But maybe by the time that commit gets in
> we'll have figured out this last crash and corrected it as well.
> Sticking to just the first two logs is fine by me.
>
>
> >
> > So it seems reasonable to drop test from auto group at least until we
> > merge "block: update graph permissions update"
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >
> > Note: be free to shorten commit message if needed :)
>
> Indeed.  But as to the patch itself, I agree, and may Peter wants to
> apply it directly to master instead of waiting for it to come through on
> of the block maintainers?
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks; I have applied this to master, after trimming the
part of the commit message that refers to as-yet-unapplied
patch series.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]