[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] migration: dirty-bitmap: Allow control of bitmap persist
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [PATCH 2/2] migration: dirty-bitmap: Allow control of bitmap persistence on destination |
|
Date: |
Wed, 3 Feb 2021 16:23:21 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
03.02.2021 16:00, Peter Krempa wrote:
Bitmap's source persistence is transported over the migration stream and
the destination mirrors it. In some cases the destination might want to
persist bitmaps which are not persistent on the source (e.g. the result
of merge of bitmaps from a number of layers on the source when migrating
into a squashed image)
Why not make merge target on source be persistent itself? Then it will be
persistent on migration destination.
but currently it would need to create another set
of persistent bitmaps and merge them.
This adds 'dest-persistent' optional property to
'BitmapMigrationBitmapAlias' which when present overrides the bitmap
presence state from the source.
It's seems simpler to make a separate qmp command
block-dirty-bitmap-make-persistent.. Didn't you consider this way?
--
Best regards,
Vladimir