Re: [PATCH] iotests/118: Drop 'change' test

[Paolo Bonzini]

On 26/01/21 11:48, Max Reitz wrote:
> Commit 0afec75734331 removed the 'change' QMP command, so we can no
> longer test it in 118.
>
> Fixes: 0afec75734331a0b52fa3aa4235220eda8c7846f
>         ('qmp: remove deprecated "change" command')
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   tests/qemu-iotests/118     | 17 -----------------
>   tests/qemu-iotests/118.out |  4 ++--
>   2 files changed, 2 insertions(+), 19 deletions(-)

How come this didn't break GitLab CI?...

Paolo

> diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118
> index 1a2e219057..88e8354e21 100755
> --- a/tests/qemu-iotests/118
> +++ b/tests/qemu-iotests/118
> @@ -74,23 +74,6 @@ class ChangeBaseClass(iotests.QMPTestCase):
>   
>   class GeneralChangeTestsBaseClass(ChangeBaseClass):
>   
> -    def test_change(self):
> -        # 'change' requires a drive name, so skip the test for blockdev
> -        if not self.use_drive:
> -            return
> -
> -        result = self.vm.qmp('change', device='drive0', target=new_img,
> -                                       arg=iotests.imgfmt)
> -        self.assert_qmp(result, 'return', {})
> -
> -        self.wait_for_open()
> -        self.wait_for_close()
> -
> -        result = self.vm.qmp('query-block')
> -        if self.has_real_tray:
> -            self.assert_qmp(result, 'return[0]/tray_open', False)
> -        self.assert_qmp(result, 'return[0]/inserted/image/filename', new_img)
> -
>       def test_blockdev_change_medium(self):
>           result = self.vm.qmp('blockdev-change-medium',
>                                id=self.device_name, filename=new_img,
> diff --git a/tests/qemu-iotests/118.out b/tests/qemu-iotests/118.out
> index bf5bfd5aca..0a70391105 100644
> --- a/tests/qemu-iotests/118.out
> +++ b/tests/qemu-iotests/118.out
> @@ -1,5 +1,5 @@
> -.......................................................................................................................................................................
> +...........................................................................................................................................................
>   ----------------------------------------------------------------------
> -Ran 167 tests
> +Ran 155 tests
>   
>   OK