Re: [PATCH v7 00/11] Rework iotests/check

[Vladimir Sementsov-Ogievskiy]

22.01.2021 14:27, Kevin Wolf wrote:
> Am 20.01.2021 um 21:52 hat Eric Blake geschrieben:
> > On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote:
> > > Hi all!
> > >
> > > These series has 3 goals:
> > >
> > >   - get rid of group file (to forget about rebase and in-list conflicts)
> > >   - introduce human-readable names for tests
> > >   - rewrite check into python
> > >
> > > v7:
> > >    - fix wording and grammar
> > >    - satisfy python linters
> > >    - move argv interfaces all into one in new check script
> > >    - support '-n' == '--dry-run' option
> > >    - update check-block to run check with correct PYTHON
> >
> > I'd really like a second reviewer on 7-11, but I'm queueing 1-6 on my
> > NBD tree now.
>
> Oh, you already sent a pull request? Having 6 in without the rest is not
> a good state. We now have the group info duplicated and one of them is
> ignored, but will become the meaningful copy later. We need to be
> careful to not let them diverge now.
>
> I hope the rest is fine so we can switch over quickly, otherwise I'd
> prefer to revert 6 and redo it from the then current state when we merge
> the whole series.

I can make a new version now with tiny fixes suggested by Eric if it is 
convenient. (and keep --color suggestion for a separate follow-up)



--
Best regards,
Vladimir